Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: trackers #1320

Merged
merged 48 commits into from
Oct 25, 2023
Merged

test: trackers #1320

merged 48 commits into from
Oct 25, 2023

Conversation

kingpinXD
Copy link
Contributor

@kingpinXD kingpinXD commented Oct 19, 2023 •
edited
Loading

Description

Closes: #1269
Closes: #1321

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

kingpinXD and others added 30 commits September 7, 2023 22:48
@kingpinXD
add msgs and query for inTxTracker
fdda86d
@kingpinXD
add unit tests
b989fe4
@kingpinXD
Generate specs
e3beb86
@kingpinXD
add intx tracker to genesis export
065bdc1
@kingpinXD
feat: zetaclient read logs functions (#1118)
b764bf7
@kingpinXD
add function to delete intx trackers
ae379a6
@kingpinXD
change to remove tracker if exists
acfc130
@kingpinXD
add debug cli
3d86a5e
@kingpinXD
add debug cli
83290a7
@kingpinXD
add btc inboud tracker
306f5ef
@kingpinXD
add intx debugger for btc
994ec15
@kingpinXD
rebase develop and fix smoketest
f96feeb
@kingpinXD
add optional block header verification on inbound tracker
978c742
@kingpinXD
fix lint
5bbb371
@kingpinXD
remove keeper prefix
1bdd724
@kingpinXD
fix comments
eb9aef8
@kingpinXD
Merge branch 'develop' into inbound-tracker
33751fe
@kingpinXD
fix comments
28b5f1c
@kingpinXD
modify cli commands
1269476
@kingpinXD
resolve comments 1
fc4198e
@kingpinXD
add check for cointype
509b655
@kingpinXD
Merge branch 'develop' into inbound-tracker
e22b41b
@kingpinXD
Merge branch 'develop' into inbound-tracker
feaecc1
@kingpinXD
add flag to disable block header based verifications
14fe715
@kingpinXD
Merge remote-tracking branch 'origin/inbound-tracker' into inbound-tr…
5e50e89 
…acker
@kingpinXD
add upgrade script for legacy crosschain flags
f957401
@kingpinXD
add test for upgrade script
1bc7e56
@kingpinXD
add issue to track intx tracker tests
8db3339
@kingpinXD
removed redundant add to intx tracker list
fe4d213
@kingpinXD
modify to iterating of receipt.logs
30b8199
@kingpinXD kingpinXD changed the title Intx tracker tests test: trackers Oct 19, 2023
lumtis
lumtis reviewed Oct 19, 2023
View reviewed changes
Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests looks good to me. Left a few comments.

testutil/keeper/crosschain.go Show resolved Hide resolved
x/crosschain/keeper/keeper_cross_chain_tx_vote_inbound_tx.go Show resolved Hide resolved
x/crosschain/keeper/msg_server_add_to_intx_tracker.go Outdated Show resolved Hide resolved
x/crosschain/keeper/msg_server_add_to_intx_tracker.go Outdated Show resolved Hide resolved
x/crosschain/keeper/msg_server_add_to_intx_tracker.go Outdated Show resolved Hide resolved
x/crosschain/keeper/msg_server_add_to_outtx_tracker_test.go Outdated Show resolved Hide resolved
x/crosschain/keeper/msg_server_add_to_intx_tracker_test.go Outdated Show resolved Hide resolved
x/crosschain/keeper/msg_server_add_to_intx_tracker.go Outdated Show resolved Hide resolved
x/crosschain/keeper/msg_server_add_to_intx_tracker.go Outdated Show resolved Hide resolved
x/crosschain/keeper/msg_server_add_to_intx_tracker_test.go Outdated Show resolved Hide resolved
@kingpinXD kingpinXD requested a review from lumtis October 20, 2023 20:43
lumtis
lumtis approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.
I think one of the test is failed because there is a setAdminPolicies(ctx, zk, admin) missing

ws4charlie
ws4charlie approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@ws4charlie ws4charlie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@kingpinXD kingpinXD merged commit 0c3d90f into develop Oct 25, 2023
13 checks passed
@lumtis lumtis deleted the intx_tracker-tests branch October 27, 2023 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ws4charlie ws4charlie ws4charlie approved these changes

@lumtis lumtis lumtis approved these changes

@brewmaster012 brewmaster012 Awaiting requested review from brewmaster012

@kevinssgh kevinssgh Awaiting requested review from kevinssgh

@fadeev fadeev Awaiting requested review from fadeev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

crosschain : add tests for out_tx_tracker crosschain : add tests for in_tx_tracker
3 participants
@kingpinXD @lumtis @ws4charlie